Re: [PATCH 2/2] mm/mempolicy: Skip unnecessary synchronize_rcu()

[Huang, Ying]

Joshua Hahn <joshua.hahnjy@xxxxxxxxx> writes:

> By unconditionally setting wi_state to NULL and conditionally calling
> synchronize_rcu(), we can save an unncessary call when there is no
> old_wi_state.

Per my understanding, in the original code, if !old_wi_state, we will
return immediately instead of calling synchronize_rcu() too.  Or I miss
something?

The patch itself is a nice cleanup with reduced line number.  Feel free
to add my

Reviewed-by: Huang Ying <ying.huang@xxxxxxxxxxxxxxxxx>

in the future version.

> Suggested-by: David Hildenbrand <david@xxxxxxxxxx>
> Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
> ---
>  mm/mempolicy.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 3b1dfd08338b..b0619d0020c9 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -3703,18 +3703,15 @@ static void wi_state_free(void)
>  	struct weighted_interleave_state *old_wi_state;
>  
>  	mutex_lock(&wi_state_lock);
> -
>  	old_wi_state = rcu_dereference_protected(wi_state,
>  			lockdep_is_held(&wi_state_lock));
> -	if (!old_wi_state) {
> -		mutex_unlock(&wi_state_lock);
> -		return;
> -	}
> -
>  	rcu_assign_pointer(wi_state, NULL);
>  	mutex_unlock(&wi_state_lock);
> -	synchronize_rcu();
> -	kfree(old_wi_state);
> +
> +	if (old_wi_state) {
> +		synchronize_rcu();
> +		kfree(old_wi_state);
> +	}
>  }
>  
>  static struct kobj_attribute wi_auto_attr =

---
Best Regards,
Huang, Ying