Re: [RFC PATCH 01/10] net: dsa: b53: add support for FDB operations on 5325/5365

[Florian Fainelli]

On 5/31/25 03:12, Álvaro Fernández Rojas wrote:
> From: Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> BCM5325 and BCM5365 are part of a much older generation of switches which,
> due to their limited number of ports and VLAN entries (up to 256) allowed
> a single 64-bit register to hold a full ARL entry.
> This requires a little bit of massaging when reading, writing and
> converting ARL entries in both directions.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>

Regarding your error in the cover letter which are mostly -ENOSPC, I 
believe the problem is that b53_arl_read() is still looking for 
ARLTBL_VALID rather than ARLTBL_VALID_25.

Given there is no VID returned upon an ARL ready with the 5325, I don't 
know how to also reconcile that line:

                if (dev->vlan_enabled &&
                    ((mac_vid >> ARLTBL_VID_S) & ARLTBL_VID_MASK) != vid)
                        continue;


--
Florian