Re: [PATCH v3 0/3] pwm: axi-pwmgen: add external clock
From: Uwe Kleine-König
Date: Mon Jun 02 2025 - 12:39:52 EST
Hello David,
On Thu, May 29, 2025 at 11:53:17AM -0500, David Lechner wrote:
> When we created the driver for the AXI PWMGEN IP block, we overlooked
> the fact that it can optionally be configured to use an external clock
> in addition to the AXI bus clock. This is easy to miss in testing
> because the bus clock is always on because it is driving other
> peripherals as well.
>
> Up to now, users were specifying the external clock if there was one and
> the AXI bus clock otherwise. But the proper way to do this is to would
> be to always specify the bus clock and only specify the external clock
> if the IP block has been configured to use it.
>
> To fix this, we add clock-names to the devicetree bindings and change
> clocks to allow 1 or 2 clocks.
I applied path #1 for 6.17-rc1 and will send patches #2 and #3 to Linus
before 6.16.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature