Re: [PATCH 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format

[Andrew Lunn]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/lpc18xx-ccu.h>
> +
> +    ethernet@40010000 {
> +        compatible = "nxp,lpc1850-dwmac", "snps,dwmac-3.611", "snps,dwmac";
> +        reg = <0x40010000 0x2000>;
> +        interrupts = <5>;
> +        interrupt-names = "macirq";
> +        clocks = <&ccu1 CLK_CPU_ETHERNET>;
> +        clock-names = "stmmaceth";
> +        resets = <&rgu 22>;
> +        reset-names = "stmmaceth";
> +        phy-mode = "rgmii";

Please don't use 'rgmii' in an example, because it is 99% of the time
wrong. You are just encouraging developers to copy/paste this into
real DT blobs, and then i need to point out it is wrong. Use
'rgmii-id', which is much more likely to be correct.

	Andrew