Re: [PATCH v3] rust: doc: Clean up formatting in io.rs

From: Miguel Ojeda
Date: Mon Jun 02 2025 - 10:37:15 EST


On Mon, Jun 2, 2025 at 1:11 PM Sai Vishnu <saivishnu725@xxxxxxxxx> wrote:
>
> Is it the one below the Signed off by line? To get the complete picture:

Yes, after that and before the diffstat -- please check some examples
in the list as Greg suggests.

> Additionally, I suppose the `base-commit` tag should also be placed in
> 3 (above/below Signed-off-by), as it was added to the very end by
> `git` when generating the patch.

Where Git adds it should be fine :)

In fact, if you have a good Git commit, and you use the right flags,
then Git can take care of essentially everything for you, i.e. you
should not generally need to edit much (or anything at all), though
you may or may not want to use some of its features, e.g. notes and
branch descriptions. Please take a look at `man git-format-patch`.

Thanks!

Cheers,
Miguel