Re: [syzbot] [cgroups?] general protection fault in __cgroup_rstat_lock

[Michal Koutný]

On Sun, Jun 01, 2025 at 09:21:02AM -0700, syzbot <syzbot+31eb4d4e7d9bc1fc1312@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> syzbot suspects this issue was fixed by commit:
> 
> commit a97915559f5c5ff1972d678b94fd460c72a3b5f2
> Author: JP Kobryn <inwardvessel@xxxxxxxxx>
> Date:   Fri Apr 4 01:10:48 2025 +0000
> 
>     cgroup: change rstat function signatures from cgroup-based to css-based

It says: "This non-functional change serves..."

However, it moves the *_rstat_init in cgroup_create() after kernfs dir
creation and given the reproducer has a fault injected:
	mkdir(&(0x7f0000000000)='./cgroup/file0\x00', 0xd0939199c36b4d28) (fail_nth: 8)

I'd say this might be relevant (although I don't see the possibly
incorrect error handlnig path) but it doesn't mean this commit fixes it,
it'd rather require the reproducer to adjust the N on this path.

0.02€,
Michal

Attachment: signature.asc
Description: PGP signature