Re: [PATCH v3 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support

[Andrew Lunn]

> > So shouldn't there be an else clause here setting these two values to
> > their default, undoing what the bootloader might of done etc.
> 
> DAC values are only set if the property is set in the DTS. If the property
> is not set, the default values set by the PHY itself are used, and as you
> mentioned below, DAC values aren't modified by the driver.
> 
> > 
> > Or you can change the binding, and say something like:
> > 
> > +            If not set, DAC values are not modified.
> 
> sure, anything else you need changed for v4?

We have seen cases where the bootloader does the wrong thing, e.g. in
this case, hard coded for short cable. A DT developer than looks at
the binding, sees that the defaults should be used, and are confused.
By accurately wording the binding, that the values are left untouched,
it gives the DT developer a hint where to look, at the bootloader.

So in general, i tend to be picky about what does it mean if the
property is not present, because its a detail which is often
overlooked.

I did not notice anything else, but net-next is closed at the moment
for the merge window, so you need to wait a while before submitting it
for merging.

	Andrew