Re: [PATCH v3 3/3] arm64: qcom: sc7280: Move phy, perst to root port node

From: Krzysztof Kozlowski
Date: Mon Jun 02 2025 - 09:02:04 EST


On 08/05/2025 16:26, Konrad Dybcio wrote:
> On 4/23/25 5:37 PM, Rob Herring wrote:
>> On Sat, Apr 19, 2025 at 10:49:26AM +0530, Krishna Chaitanya Chundru wrote:
>>> There are many places we agreed to move the wake and perst gpio's
>>> and phy etc to the pcie root port node instead of bridge node[1].
>>>
>>> So move the phy, phy-names, wake-gpio's in the root port.
>>> There is already reset-gpio defined for PERST# in pci-bus-common.yaml,
>>> start using that property instead of perst-gpio.
>>
>> Moving the properties will break existing kernels. If that doesn't
>> matter for these platforms, say so in the commit msg.
>
> I don't think we generally guarantee *forward* dt compatibility though, no?
We do not guarantee, comment was not about this, but we expect. This DTS
is supposed and is used by other projects. There was entire complain
last DT BoF about kernel breaking DTS users all the time.

Best regards,
Krzysztof