Re: [PATCH 17/32] x86/boot/e820: Standardize e820 table index variable names under 'idx'
From: Nikolay Borisov
Date: Mon Jun 02 2025 - 08:37:41 EST
On 5/15/25 15:05, Ingo Molnar wrote:
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Andy Shevchenko <andy@xxxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
Cc: David Woodhouse <dwmw@xxxxxxxxxxxx>
Cc: H. Peter Anvin <hpa@xxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
---
arch/x86/kernel/e820.c | 114 ++++++++++++++++++++++++-------------------------
1 file changed, 57 insertions(+), 57 deletions(-)
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 806d69ca09af..3ee266673fee 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -75,10 +75,10 @@ EXPORT_SYMBOL(pci_mem_start);
static bool _e820__mapped_any(struct e820_table *table,
u64 start, u64 end, enum e820_type type)
{
- int i;
+ int idx;
- for (i = 0; i < table->nr_entries; i++) {
- struct e820_entry *entry = &table->entries[i];
+ for (idx = 0; idx < table->nr_entries; idx++) {
+ struct e820_entry *entry = &table->entries[idx];
nit: Since the kernel supports gnu11 since e8c07082a810f what's your
take on defining the variables inside the for loop?
if (type && entry->type != type)
continue;
<snip>