Re: [PATCH v4 11/20] gpu: nova-core: wait for GFW_BOOT completion
From: Alexandre Courbot
Date: Mon Jun 02 2025 - 07:21:49 EST
On Sat May 31, 2025 at 11:37 PM JST, Danilo Krummrich wrote:
> On Sat, May 31, 2025 at 04:09:29PM +0200, Miguel Ojeda wrote:
>> On Fri, May 30, 2025 at 11:51 PM Lyude Paul <lyude@xxxxxxxxxx> wrote:
>> > TBH - we should really add some safe bindings for sleeps instead of calling
>> > this unsafely, I'd be happy to review them if you do
>>
>> In case it helps, there is:
>>
>> https://lore.kernel.org/rust-for-linux/20250423192857.199712-6-fujita.tomonori@xxxxxxxxx/
>>
>> I think that is the last one -- we have been going back and forth a
>> bit on it (e.g. we had `coarse_sleep()` in the old `rust` pre-merge
>> branch), but, yeah, let's try to get the abstraction(s) in.
>
> We've already discussed this on previous versions of this patch series, where I
> also pointed to the patch series linked above.
>
> I agreed to take this code without waiting for those abstractions, but with a
> TODO to fix things up once they land.
Added the missing TODO for this.