Re: [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties

From: Krzysztof Kozlowski
Date: Mon Jun 02 2025 - 07:18:59 EST


On 02/06/2025 13:10, Akhil R wrote:
>>
>>> + Module reset. This property is optional for controllers in Tegra194 and later
>>
>> Your binding says Tegra210 requires it, but 210 feels like something
>> later than 194. Maybe that's obvious for people knowing that device?
>
> Tegra210 is in fact an older device than T194. I will probably mention the chip names
> instead of “later” in the next version.
>
>>
>> Anyway, please wrap at 80 (see kernel coding style).
>
> Okay. Will update.
> checkpatch.pl don’t warn now till 100 characters. I thought it was updated.

Checkpatch is a tool, not coding style. Coding style document describes
the coding style.



Best regards,
Krzysztof