Re: [PATCH] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO
From: Eric Dumazet
Date: Mon Jun 02 2025 - 05:56:25 EST
On Mon, Jun 2, 2025 at 1:50 AM ALOK TIWARI <alok.a.tiwari@xxxxxxxxxx> wrote:
>
> Hi Mina,
>
> On 02-06-2025 01:21, ALOK TIWARI wrote:
> > Patch itself looks good to me, but if you can, please designate it to
> > the net tree by prefixing the patch with `[PATCH net v2]` as mentioned
> > in our docs:
> >
> > https://urldefense.com/v3/__https://docs.kernel.org/process/maintainer-
> > netdev.html__;!!ACWV5N9M2RV99hQ!JPpnRT9itx84rhzAaeGelVD-
> > bnJR8vFksx2OjGzAKZWf_A6o8hEY0CUMMUO_NuSStcCyBGnvhoJAJlADszR4D_aj$
> >
> > Also, if possible, add `Fixes: commit a57e5de476be ("gve: DQO: Add TX
> > path")` to give it a chance to get picked up by stable trees.
>
> I believe commit a6fb8d5a8b69 is a more natural and appropriate
> candidate for the Fixes tag compared to a57e5de476be
> What’s your take on this, Mina?
Mina is right. Bug was added back in 2021.
Fixes: a57e5de476be ("gve: DQO: Add TX path")