Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

[Stephan Gerhold]

On Sat, May 31, 2025 at 02:27:18PM +0200, Konrad Dybcio wrote:
> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@xxxxxxxxxxx>
> 
> No external dependencies
> 

Are you sure?

> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> Konrad Dybcio (5):
>       arm64: dts: qcom: msm8916: Add Venus OPP table
>       arm64: dts: qcom: msm8996: Add Venus OPP table
>       arm64: dts: qcom: msm8998: Add Venus OPP table
>       arm64: dts: qcom: sdm630: Add Venus OPP table

None of these platforms has a power domain that supports performance
states specified in the venus node of the DT, and the venus GDSC does
not have any parent either. I think you will need to update the venus
bindings and add

	.opp_pmdomain = (const char *[]) { "cx" /*???*/ },

for all these in the venus driver (plus backwards compat if not already
there). And then add that power domain additionally in the DT.

This series is also introducing new dtbs_check failures :/

qcom/apq8016-sbc.dtb: video-codec@1d00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                               
        from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#         
qcom/apq8096-db820c.dtb: video-codec@c00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                             
        from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#     
qcom/msm8998-lenovo-miix-630.dtb: video-codec@cc00000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                   
        from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#       

>       arm64: dts: qcom: sdm845: Fix Venus OPP entries

This one has .opp_pmdomain and "cx" in the bindings, so it's probably
fine (didn't check if the current OPPs are really wrong).

Thanks,
Stephan