Re: [PATCH 1/4] dt-bindings: usb: Add compatible strings for s32g2/s32g3

From: Dan Carpenter
Date: Mon Jun 02 2025 - 01:49:27 EST


On Wed, May 28, 2025 at 05:22:36PM -0400, Frank Li wrote:
> On Wed, May 28, 2025 at 10:57:10PM +0300, Dan Carpenter wrote:
> > From: Ghennadi Procopciuc <ghennadi.procopciuc@xxxxxxx>
> >
> > Add the compatible strings for the NXP s32g2 and s32g3.
> >
> > Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxx>
> > Signed-off-by: Ionut Vicovan <Ionut.Vicovan@xxxxxxx>
> > Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@xxxxxxx>
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++
> > Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > index cc5787a8cfa3..400d885fea96 100644
> > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> > @@ -24,6 +24,8 @@ properties:
> > - nvidia,tegra114-udc
> > - nvidia,tegra124-udc
> > - qcom,ci-hdrc
> > + - nxp,s32g2-usb
> > + - nxp,s32g3-usb
>
> keep alphabet order!

Ah, sure.

> Can you use b4 to send patch, look like cc list missed
> imx@xxxxxxxxxxxxxxx

It's MAINTAINERS file which is wrong here.

$ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (maintainer:USB SUBSYSTEM)
Rob Herring <robh@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <conor+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Xu Yang <xu.yang_2@xxxxxxx> (in file)
Peng Fan <peng.fan@xxxxxxx> (in file)
linux-usb@xxxxxxxxxxxxxxx (open list:USB SUBSYSTEM)
devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@xxxxxxxxxxxxxxx (open list)
USB SUBSYSTEM status: Supported

regards,
dan carpenter