[PATCH 2/2] dmaengine: qcom_hidma: fix handoff FIFO memory leak on driver removal
From: Qasim Ijaz
Date: Sun Jun 01 2025 - 18:43:22 EST
hidma_ll_init() allocates a handoff FIFO, but the matching
hidma_ll_uninit() function (which is invoked in remove())
never releases it, leaking memory.
To fix this call kfifo_free in hidma_ll_uninit().
Fixes: d1615ca2e085 ("dmaengine: qcom_hidma: implement lower level hardware interface")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Qasim Ijaz <qasdev00@xxxxxxxxx>
---
drivers/dma/qcom/hidma_ll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/qcom/hidma_ll.c b/drivers/dma/qcom/hidma_ll.c
index fee448499777..0c2bae46746c 100644
--- a/drivers/dma/qcom/hidma_ll.c
+++ b/drivers/dma/qcom/hidma_ll.c
@@ -816,6 +816,7 @@ int hidma_ll_uninit(struct hidma_lldev *lldev)
required_bytes = sizeof(struct hidma_tre) * lldev->nr_tres;
tasklet_kill(&lldev->task);
+ kfifo_free(&lldev->handoff_fifo);
memset(lldev->trepool, 0, required_bytes);
lldev->trepool = NULL;
atomic_set(&lldev->pending_tre_count, 0);
--
2.39.5