Re: [PATCH] gpio: TODO: add a task for removing MMIO-specific fields from gpio_chip

From: Linus Walleij
Date: Sun Jun 01 2025 - 14:56:33 EST


On Tue, May 27, 2025 at 1:14 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Currently for CONFIG_GPIO_GENERIC=y each struct gpio_chip object
> contains the fields relevant only for gpio-mmio users. It's not an
> insignificant number either as it's several pointers and integers.
>
> It makes sense to remove these fields from struct gpio_chip into a
> dedicated structure but this is not trivial due to how the bgpio_init()
> function is implemented.
>
> Add a task for tracking this rework.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>

That's a good TODO.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij