Re: [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier

[Krzysztof Kozlowski]

On 01/06/2025 14:52, Prasad Kumpatla wrote:
> 
> 
> On 5/27/2025 5:29 PM, Krzysztof Kozlowski wrote:
>> On 27/05/2025 13:12, Prasad Kumpatla wrote:
>>> +	left_spkr: speaker@0,1 {
>>> +		compatible = "sdw10217020200";
>>> +		reg = <0 1>;
>>> +		powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>>> +		#sound-dai-cells = <0>;
>>> +		sound-name-prefix = "SpkrLeft";
>>> +		#thermal-sensor-cells = <0>;
>>> +		vdd-supply = <&vreg_l18b_1p8>;
>>> +		qcom,port-mapping = <1 2 3 7>;
>>> +	};
>>> +
>>> +	right_spkr: speaker@0,2 {
>>> +		compatible = "sdw10217020200";
>>> +		reg = <0 2>;
>>> +		powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>>
>>
>> This will fail during runtime. You never booted your DTS.
> 
> No, its working fine, didn't seen any issues for far. Please help to 
> provide at which point of line seen issue or provide more context to 
> understand for me?
Okay, so the driver uses non-exclusive GPIO. Well, this should be really
fixed now. There is no excuse now "cannot work", because I fixed WSA884x
so new DTS using this method should not be allowed. Non-exclusive in
this driver is buggy and works by pure coincidence. You should see clear
warnings and issues during probe, because working device WILL be reset
by the other device.

Best regards,
Krzysztof