Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution

[Krzysztof Kozlowski]

On 01/06/2025 14:45, Prasad Kumpatla wrote:
>>>         properties:
>>>           clocks:
>>> -          maxItems: 1
>>> +          minItems: 1
>>> +          maxItems: 3
>>>           clock-names:
>>> -          items:
>>> -            - const: mclk
>>> +          oneOf:
>>> +            - items:   # for ADSP based platforms
>>> +                - const: mclk
>>> +                - const: macro
>>> +                - const: dcodec
>>> +            - items:   # for ADSP bypass based platforms
>>> +                - const: mclk
>>
>> This device always receives same amount of clocks. Hardware is not
>> different if you decide to not use ADSP.
> for sc7280 clock handling only supports non-DSP based solution, macro

ONLY?

> and dcodec votes are placed using CPU-Powerdomains. Which are not under
> clocking properties. In ADSP based platforms macro and dcodec votes 
> should be placed from ADSP.>

I don't understand this, that's barely a sentence. Anyway if that's
ONLY, then seems pretty fixed and I don't get why you make it flexible.

Expressing clocks as CPU powerdomains is not really correct.



Best regards,
Krzysztof