Re: [PATCH net-next v3 5/8] gve: Add support to query the nic clock

[Jakub Kicinski]

On Thu, 22 May 2025 23:57:34 +0000 Harshitha Ramamurthy wrote:
> +	err = gve_ptp_init(priv);
> +	if (err)
> +		return err;
> +
> +	priv->nic_ts_report =
> +		dma_alloc_coherent(&priv->pdev->dev,
> +				   sizeof(struct gve_nic_ts_report),
> +				   &priv->nic_ts_report_bus,
> +				   GFP_KERNEL);
> +	if (!priv->nic_ts_report) {
> +		dev_err(&priv->pdev->dev, "%s dma alloc error\n", __func__);

missing a call to gve_ptp_release() on this error path?

> +		return -ENOMEM;
> +	}
-- 
pw-bot: cr