Re: [PATCH v12 20/21] selftests/futex: Add futex_priv_hash

[Mark Brown]

On Tue, May 27, 2025 at 03:25:33PM +0200, Sebastian Andrzej Siewior wrote:
> On 2025-05-27 13:59:38 [+0100], Mark Brown wrote:

> >    https://builds.sirena.org.uk/cda95faef7bcf26ba3f54c3cddce66d50116d146/arm64/defconfig/build.log
> >    https://builds.sirena.org.uk/cda95faef7bcf26ba3f54c3cddce66d50116d146/arm64/defconfig/kselftest.tar.xz

> > (note that this is the specific commit that I'm replying to the patch

> Ach, okay. I assumed you had the master branch as of today. The whole
> KTAP/ machine readable output was added later.



> > for, not -next.)  It looks like it's something's getting mistbuilt or
> > there's some logic bug with the argument parsing, if I run the binary
> > with -h it exits with return code 0 rather than 1.

> I copied the logic from the other tests in that folder. If you set -h (a
> valid argument) then it exits with 0. If you an invalid argument it
> exits with 1.

Yeah, so it was actually parsing arguments.

> But now that I start the binary myself, it ends the same way. This
> cures it:

>  	int ret;
> -	char c;
> +	int c;
>  
>  	while ((c = getopt(argc, argv, "cghv:")) != -1) {

Ah, yes - that'd do it.  Looking at the other tests there they do have c
as int.

Attachment: signature.asc
Description: PGP signature