Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

[Andrew Lunn]

> I couldn't agree more but I just don't know what these values are exactly as
> they aren't documented anywhere. I'm working off the downstream QCA-SSDK
> codelinaro repo. My *best guess* for the MDAC value is that it halves the
> amplitude and current for short cable length, but I don't know what
> algorithm is used for error detection and correction.
> 
> What I do know is that values must be written in a phy to phy link
> architecture as the 'cable length' is short, a few cm at most. Without
> setting these values, the link doesn't work.
> 
> With the lack of proper documentation, I could move the values to the driver
> itself and convert it to a boolean property such as qca,phy-to-phy-dac or
> something..

Making it a boolean property is good. Please include in the binding
the behaviour when the bool is not present.

What you are really describing here is a sort cable, not phy-to-phy,
since a PHY is always connected to another PHY. So i think the
property name should be about the sort cable/distance.

	Andrew