Re: [PATCH 3/3] input: docs: Fix Amiga joysticks grammar & formatting

From: Jonathan Corbet
Date: Mon May 26 2025 - 08:48:32 EST


Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes:

> On Mon, May 26, 2025 at 02:14:43AM +0100, George Anthony Vernon wrote:
>> Make small grammar fixes to Amiga joystick documentation.
>>
>> Also make heading adornments compliant with the guidelines to improve
>> organisation of the page.
>
> Split up these two changes into separate patches.

The word "also" in a changelog is indeed a hint that a patch is doing
too many things.

For a simple patch like this, though, I would not force a resend just
for that.

>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>> -Amiga joystick extensions
>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>> +===============
>> +Amiga joysticks
>> +===============
>
> I would prefer to keep section adornments in this doc as-is, though.

...and why...? We have a standard progression, why not use it?

jon