Re: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()

From: Tommaso Merciai
Date: Mon May 26 2025 - 05:22:20 EST


Hi Geert,
Thanks for your comment.

On 26/05/25 11:13, Geert Uytterhoeven wrote:
Hi Tommaso,

On Mon, 26 May 2025 at 10:55, Tommaso Merciai
<tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
After adv7511_mode_set() was merged into .atomic_enable(), only the
native resolution is working when using modetest.

This is caused by incorrect timings: adv7511_mode_set() must not be
merged into .atomic_enable().

Move adv7511_mode_set() back to the .mode_set() callback in
drm_bridge_funcs to restore correct behavior.

Thanks for your patch!

Fixes: 0a9e2f0a6466 ("drm/bridge: adv7511: switch to the HDMI connector helpers")

I can't find that commit? I guess you mean:
Fixes: ae01d3183d2763ed ("drm/bridge: adv7511: switch to the HDMI
connector helpers")

Yes, sorry.
You are completely right!

https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/bridge/adv7511?id=ae01d3183d2763ed27ab71f4ef5402b683d9ad8a


Gr{oetje,eeting}s,

Geert


Thanks & Regards,
Tommaso