Re: [PATCH v4 1/4] s390: remove unneeded includes

From: Heiko Carstens
Date: Mon May 26 2025 - 04:29:01 EST


On Fri, May 23, 2025 at 03:03:45PM +0200, Claudio Imbrenda wrote:
> Many files don't need to include asm/tlb.h or asm/gmap.h.
> On the other hand, asm/tlb.h does need to include asm/gmap.h.
>
> Remove all unneeded includes so that asm/tlb.h is not directly used by
> s390 arch code anymore. Remove asm/gmap.h from a few other files as
> well, so that now only KVM code, mm/gmap.c, and asm/tlb.h include it.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Schlameuss <schlameuss@xxxxxxxxxxxxx>
> Reviewed-by: Steffen Eiden <seiden@xxxxxxxxxxxxx>
> ---
> arch/s390/include/asm/tlb.h | 1 +
> arch/s390/include/asm/uv.h | 1 -
> arch/s390/kvm/intercept.c | 1 +
> arch/s390/mm/fault.c | 1 -
> arch/s390/mm/gmap.c | 1 -
> arch/s390/mm/init.c | 1 -
> arch/s390/mm/pgalloc.c | 2 --
> arch/s390/mm/pgtable.c | 1 -
> 8 files changed, 2 insertions(+), 7 deletions(-)

Please change the subject so the first character after "s390: " is an
upper case character, like it is supposed to be the case for all s390
related patches. For "KVM: s390:" there seems to be no consistent
rule, but that's your playground.

Anyway:
Acked-by: Heiko Carstens <hca@xxxxxxxxxxxxx>