Re: [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter flag for SD card

[Sarthak Garg]

On 11/7/2024 3:29 PM, Krzysztof Kozlowski wrote:
> On Thu, Nov 07, 2024 at 01:35:03PM +0530, Sarthak Garg wrote:
> > Introduce a flag to indicate if the Qualcomm platform has a level
> > shifter for SD cards. With level shifter addition some extra delay is
> > seen on RX data path leading to CRC errors. To compensate these delays
> > and avoid CRC errors below things needs to be done:
> >
> > 1) Enable tuning for SDR50 mode
> > 2) Limit HS mode frequency to 37.5MHz from 50MHz
> >
> > Add this flag for all targets with a level shifter to handle these
> > issues for SD card.
> >
> > Signed-off-by: Sarthak Garg <quic_sartgarg@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 +++
> >   1 file changed, 3 insertions(+)
>
> This wasn't tested, so just short review - platform means SoC usually,
> so this looks SoC specific, thus implied by compatible.
>  > Best regards,
> Krzysztof

Sure will redesign this logic and use compatible in patch V2.