Re: [PATCH v4 5/6] dt-bindings: iio: adc: adi-axi-adc: add ad7405 example

[Krzysztof Kozlowski]

On Mon, May 19, 2025 at 05:02:13PM GMT, Pop Ioan Daniel wrote:
> The ad7405 device is defined as a child of the AXI ADC.

1. Why? What we see easily (although not here, because above does not
answer even to what).
2. I do not see any device being added to the binding.

> 
> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@xxxxxxxxxx>
> ---
> changes in v4:
>  - add ad7405 device that is defined as a child of the AXI ADC
>  .../bindings/iio/adc/adi,axi-adc.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index cf74f84d6103..a6bc8acd101f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -135,4 +135,21 @@ examples:
>              io-backends = <&parallel_bus_controller>;
>          };
>      };
> +  - |
> +    axi_adc@44a00000 {

Follow DTS coding style.

> +        compatible = "adi,axi-adc-10.0.a";
> +        reg = <0x44a00000 0x10000>;
> +        dmas = <&rx_dma 0>;
> +        dma-names = "rx";
> +        clocks = <&axi_clk>;
> +        #io-backend-cells = <0>;

This example is already there, so I do not get why you duplicate it.
Skip the patch or with reason add the child to the existing example.

> +
> +        adc@0 {
> +            compatible = "adi,ad7405";

Best regards,
Krzysztof