Re: [PATCH V12 06/15] rust: macros: enable use of hyphens in module names

From: Anisse Astier
Date: Tue May 20 2025 - 02:14:18 EST




Mar 20 mai 2025, à 06:33, Viresh Kumar a écrit :
> On 19-05-25, 16:15, Miguel Ojeda wrote:
>> On Mon, May 19, 2025 at 9:08 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>> >
>> > + /* Rust does not allow hyphens in identifiers, use underscore instead */
>>
>> (In case you see this before you apply)
>>
>> Nit: `//` for comments, also please end with a period.
>
> Done.

Thank you Viresh for iterating on this and picking up review comments. Do not hesitate to add your Co-developed-by.

Kind regards,

Anisse