RE: [PATCH v2 2/2] dt-bindings: gpio: vf610: add ngpios and gpio-reserved-ranges

[Bough Chen]

> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: 2025年5月20日 0:04
> To: Bough Chen <haibo.chen@xxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>;
> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Pengutronix Kernel Team
> <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; Stefan
> Agner <stefan@xxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; Bartosz
> Golaszewski <brgl@xxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-gpio@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] dt-bindings: gpio: vf610: add ngpios and
> gpio-reserved-ranges
> 
> On Mon, May 19, 2025 at 02:03:43PM +0800, Haibo Chen wrote:
> > Add optional ngpios and gpio-reserved-ranges property
> >
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> > b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> > index
> >
> 4fb32e9aec0a341a50088f3e4352ed4d36f649d3..5b98228466c6414be681c494
> 17bb
> > dd82f2c45756 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> > @@ -70,6 +70,12 @@ properties:
> >      minItems: 1
> >      maxItems: 4
> >
> > +  gpio-reserved-ranges: true
> > +
> > +  ngpios:
> > +    minimum: 1
> > +    maximum: 32
> 
> Do these platforms have a default? I'd expect one to be added that contains the
> default value from what the driver does now.

Okay, the default value should be 32, I will add that.

By the way, If add the default value, for the gpio port which contain 32 pads, seems no need to add ngpios in dts, I will change accordingly.

Regards
Haibo Chen
> 
> > +
> >  patternProperties:
> >    "^.+-hog(-[0-9]+)?$":
> >      type: object
> >
> > --
> > 2.34.1
> >