Re: [PATCH 1/4] PCI: endpoint: pci-epf-vntb: return an error code on bar init

[Frank Li]

On Mon, May 05, 2025 at 07:41:47PM +0200, Jerome Brunet wrote:

subject: s/return/Return

> According the function documentation of epf_ntb_init_epc_bar(),
> the function should return an error code on error. However, it
> returns -1 when no BAR is available.
>
> Return -EINVAL instead.
>
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

After fix above small issue about subject.

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> ---
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index e4da3fdb000723e3adad01f0ddf230ecc0e572a7..35fa0a21fc91100a5539bff775e7ebc25e1fb9c1 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -680,7 +680,7 @@ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb)
>  		barno = pci_epc_get_next_free_bar(epc_features, barno);
>  		if (barno < 0) {
>  			dev_err(dev, "Fail to get NTB function BAR\n");
> -			return barno;
> +			return -EINVAL;
>  		}
>  		ntb->epf_ntb_bar[bar] = barno;
>  	}
>
> --
> 2.47.2
>