Re: [PATCH v3] ufs: core: Add HID support

[Bart Van Assche]

On 5/18/25 7:29 PM, Huan Tang wrote:
> Follow JESD220G, support HID(Host Initiated Defragmentation)
> through sysfs, the relevant sysfs nodes are as follows:
> 	1.analysis_trigger
> 	2.defrag_trigger
> 	3.fragmented_size
> 	4.defrag_size
> 	5.progress_ratio
> 	6.state
> The detailed definition	of the six nodes can be	found in the sysfs
> documentation.
>
> HID's execution policy is given to user-space.
>
> Changelog
> ===
> v2 - > v3:
> 	1.Remove the "ufs_" prefix from directory name
> 	2.Remove the "hid_" prefix from node names
> 	3.Make "ufs" appear only once in the HID group name
> 	4.Add "is_visible" callback for "ufs_sysfs_hid_group"
> v1 - > v2:
> 	1.Refactor the HID code according to Bart and Peter and
> 	Arvi's suggestions
>
> v2
> 	https://lore.kernel.org/all/20250512131519.138-1-tanghuan@xxxxxxxx/
> v1
> 	https://lore.kernel.org/all/20250417125008.123-1-tanghuan@xxxxxxxx/
>
> Signed-off-by: Huan Tang <tanghuan@xxxxxxxx>
> Signed-off-by: Wenxing Cheng <wenxing.cheng@xxxxxxxx>
> ---

The patch changelog should occur below the three hyphens (---) such that
it doesn't end up in the kernel changelog. Otherwise this patch looks
good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>