Re: [PATCH] rust: types: remove `Either<L, R>`

From: Danilo Krummrich
Date: Mon May 19 2025 - 13:15:11 EST


On 5/19/25 2:43 PM, Benno Lossin wrote:
This enum is not used. Additionally, using it would result in poor
ergonomics, because in order to do any operation on a value it has to be
matched first. Our version of `Either` also doesn't provide any helper
methods making it even more difficult to use.

The alternative of creating a custom enum for the concrete use-case also
is much better for ergonomics. As one can provide functions on the type
directly and users don't need to match the value manually.

Signed-off-by: Benno Lossin <lossin@xxxxxxxxxx>

Reviewed-by: Danilo Krummrich <dakr@xxxxxxxxxx>