Re: [PATCH] scsi: ufs: preventing bus hang crash during emergency power off

From: Bart Van Assche
Date: Mon May 19 2025 - 11:32:29 EST


On 5/19/25 12:38 AM, Bo Ye wrote:
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 7735421e3991..a1013aea8e90 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -10262,6 +10262,7 @@ static void ufshcd_wl_shutdown(struct device *dev)
scsi_device_set_state(sdev, SDEV_OFFLINE);
mutex_unlock(&sdev->state_mutex);
}
+ ufshcd_wait_for_doorbell_clr(hba, 5 * USEC_PER_SEC);
__ufshcd_wl_suspend(hba, UFS_SHUTDOWN_PM);
/*

UFS driver kernel patches should be prepared against Martin's for-next
branch. Commit a3a951064f7e ("scsi: ufs: Rework ufshcd_clock_scaling_prepare()") removed ufshcd_wait_for_doorbell_clr().

Please fix the build failure introduced by this patch.

Bart.