Re: [PATCH v8 08/11] gpio: max7360: Add MAX7360 gpio support

[Andy Shevchenko]

On Fri, May 09, 2025 at 11:14:42AM +0200, Mathieu Dubois-Briand wrote:
> Add driver for Maxim Integrated MAX7360 GPIO/GPO controller.
> 
> Two sets of GPIOs are provided by the device:
> - Up to 8 GPIOs, shared with the PWM and rotary encoder functionalities.
>   These GPIOs also provide interrupts on input changes.
> - Up to 6 GPOs, on unused keypad columns pins.

...

> +	for (unsigned int i = 0; i < MAX7360_MAX_GPIO; ++i) {

Is there any special reaso to use pre-increment?

> +		ret = regmap_assign_bits(regmap, MAX7360_REG_PWMCFG(i),
> +					 MAX7360_PORT_CFG_INTERRUPT_MASK, mask_buf & BIT(i));
> +		if (ret)
> +			return ret;
> +	}

...

> +			for (unsigned int i = 0; i < MAX7360_MAX_GPIO; i++) {

Here, for instance, post-increment works good.

> +				ret = regmap_write_bits(regmap, MAX7360_REG_PWMCFG(i),
> +							MAX7360_PORT_CFG_INTERRUPT_EDGES,
> +							MAX7360_PORT_CFG_INTERRUPT_EDGES);
> +				if (ret)
> +					return dev_err_probe(dev, ret,
> +							     "Failed to enable interrupts\n");
> +			}

-- 
With Best Regards,
Andy Shevchenko