Re: [PATCH v5 3/5] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN]

[Huang, Kai]

On Mon, 2025-05-19 at 11:30 +0000, Reshetova, Elena wrote:
> > On Mon, 2025-05-19 at 10:24 +0300, Elena Reshetova wrote:
> > > Add error codes for ENCLS[EUPDATESVN], then SGX CPUSVN update
> > > process can know the execution state of EUPDATESVN and notify
> > > userspace.
> > > 
> > > Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx>
> > > ---
> > 
> > [...]
> > 
> > > 
> > >  /**
> > > @@ -73,6 +74,11 @@ enum sgx_encls_function {
> > >   *				public key does not match
> > IA32_SGXLEPUBKEYHASH.
> > >   * %SGX_PAGE_NOT_MODIFIABLE:	The EPC page cannot be modified
> > because it
> > >   *				is in the PENDING or MODIFIED state.
> > > + * %SGX_INSUFFICIENT_ENTROPY:	Insufficient entropy in RNG.
> > > + * %SGX_EPC_NOT_READY:			EPC is not ready for SVN
> > update.
> > > + * %SGX_NO_UPDATE:		EUPDATESVN was successful, but
> > CPUSVN was not
> > > + *				updated because current SVN was not newer
> > than
> > > + *				CPUSVN.
> > >   * %SGX_UNMASKED_EVENT:		An unmasked event, e.g. INTR, was
> > received
> > >   */
> > >  enum sgx_return_code {
> > > @@ -81,6 +87,9 @@ enum sgx_return_code {
> > >  	SGX_CHILD_PRESENT		= 13,
> > >  	SGX_INVALID_EINITTOKEN		= 16,
> > >  	SGX_PAGE_NOT_MODIFIABLE		= 20,
> > > +	SGX_INSUFFICIENT_ENTROPY	= 29,
> > > +	SGX_EPC_NOT_READY			= 30,
> > > +	SGX_NO_UPDATE				= 31,
> > >  	SGX_UNMASKED_EVENT		= 128,
> > >  };
> > > 
> > 
> > It doesn't seem SGX_EPC_NOT_READY is used in this series.
> 
> 
> You are right, not anymore. However, it is a valid return code for the EUPDATESVN command.
> Do we want to drop this one? 

I think we should drop if it is not used.