Re: [PATCH v5 1/5] x86/sgx: Introduce a counter to count the sgx_(vepc_)open()

From: Huang, Kai
Date: Mon May 19 2025 - 07:35:41 EST


On Mon, 2025-05-19 at 10:47 +0000, Huang, Kai wrote:
> > +/* Counter to count the active SGX users */
> > +static atomic64_t sgx_usage_count;
> > +
> > +int sgx_inc_usage_count(void)
> > +{
> > + atomic64_inc(&sgx_usage_count);
> > + return 0;
> > +}
>
> What's the purpose of the returning int?  Seems no caller uses the return value.

I saw your last patch uses the returning value. Perhaps add a sentence to
mention in the changelog, otherwise it's kinda out of blue.