[PATCH] net/mlx5: Add NULL check in mlx5e_tc_nic_create_miss_table
From: Charles Han
Date: Mon May 19 2025 - 07:28:15 EST
The mlx5e_tc_nic_create_miss_table() function did not check the
return value of mlx5_get_flow_namespace(). This could lead to
subsequent code using an invalid flow namespace pointer,
potentially causing crashes or undefined behavior.
Fixes: 794131c40850 ("net/mlx5: E-Switch, Return EBUSY if can't get mode lock")
Signed-off-by: Charles Han <hanchunchao@xxxxxxxxxx>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index f1d908f61134..81f0db29a2bb 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -5213,6 +5213,10 @@ static int mlx5e_tc_nic_create_miss_table(struct mlx5e_priv *priv)
ft_attr.level = MLX5E_TC_MISS_LEVEL;
ft_attr.prio = 0;
ns = mlx5_get_flow_namespace(priv->mdev, MLX5_FLOW_NAMESPACE_KERNEL);
+ if (!ns) {
+ mlx5_core_err(priv->mdev, "Failed to get flow namespace\n");
+ return -EOPNOTSUPP;
+ }
*ft = mlx5_create_auto_grouped_flow_table(ns, &ft_attr);
if (IS_ERR(*ft)) {
--
2.43.0