Re: [PATCH] ASoC: qcom: sdm845: Add error handling in sdm845_slim_snd_hw_params()

From: Dmitry Baryshkov
Date: Mon May 19 2025 - 07:02:11 EST


On Mon, May 19, 2025 at 03:57:39PM +0800, Wentao Liang wrote:
> The function sdm845_slim_snd_hw_params() calls the functuion
> snd_soc_dai_set_channel_map() but does not check its return
> value. A proper implementation can be found in msm_snd_hw_params().
>
> Add error handling for snd_soc_dai_set_channel_map(). If the
> function fails and it is not a unsupported error, return the
> error code immediately.
>
> Fixes: 5caf64c633a3 ("ASoC: qcom: sdm845: add support to DB845c and Lenovo Yoga")
> Cc: stable@xxxxxxxxxxxxxxx # v5.6
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> ---
> sound/soc/qcom/sdm845.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>

--
With best wishes
Dmitry