Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC

[Quentin Schulz]

Hi Hsun Lai,

On 5/19/25 9:54 AM, Hsun Lai wrote:
> [You don't often get email from i@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This documents Firefly ROC-RK3588S-PC which is a SBC based on RK3588S SoC.
>
> Link: https://wiki.t-firefly.com/en/Station-M3/index.html
>
> Signed-off-by: Hsun Lai <i@xxxxxxxxxx>
> ---
>
> (no changes since v1)
>
>   Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 115c3ca43..701d68aca 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -258,6 +258,11 @@ properties:
>             - const: firefly,rk3566-roc-pc
>             - const: rockchip,rk3566
>
> +      - description: Firefly Station M3
> +        items:
> +          - const: firefly,rk3588s-roc-pc

Interesting that the product seems to have two names :)

But considering the other Firefly RK35xx products do the same, I guess 
it is fine?

So:

Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>

Would you know what the actual differences are? For the Station M2 they 
say "Based on ROC-RK3566-PC" which may indicate there are some 
additional things or changes? Same for the Station P2: "Based on 
ROC-RK3568-PC".

Thanks!
Quentin