Re: [PATCH v2 4/4] LoongArch: dts: Add initial devicetree for CTCISZ Forever Pi

[Binbin Zhou]

On Mon, May 19, 2025 at 5:43 PM Yao Zi <ziyao@xxxxxxxxxxx> wrote:
>
> On Mon, May 19, 2025 at 03:58:29PM +0800, Binbin Zhou wrote:
> > Hi Yao:
> >
> > On Sun, May 18, 2025 at 4:05 PM Yao Zi <ziyao@xxxxxxxxxxx> wrote:
> > >
> > > Enable UART0 as it's the boot UART used by firmware.
> > >
> > > Signed-off-by: Yao Zi <ziyao@xxxxxxxxxxx>
> > > ---
> > >  arch/loongarch/boot/dts/Makefile              |  1 +
> > >  .../boot/dts/ls2k0300-ctcisz-forever-pi.dts   | 45 +++++++++++++++++++
> >
> > A minor suggestion:
> > As we can see, the existing dtsi/dts files are prefixed with
> > “loongosn-2k”, would it be possible to keep the filenames consistent?
>
> It's abbreviated since loongson-2k0300-ctcisz-forever-pi.dts seems a
> little too long for me, and naming devicetree files in form of
> <abbreviated-SoC-name>-<vendor>-<model> is common on other
> architectures.

Sorry, the length of the filename is not really a major concern for me.
>
> I won't insist and will change it if you consider consistency really
> matters.

Yes, I actually do mind, let's keep the naming consistent.
>
> > >  2 files changed, 46 insertions(+)
> > >  create mode 100644 arch/loongarch/boot/dts/ls2k0300-ctcisz-forever-pi.dts
>
> ...
>
> > --
> > Thanks.
> > Binbin
>
> Best regards,
> Yao Zi

-- 
Thanks.
Binbin