Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

[Chaoyi Chen]

Hi Krzysztof,

On 2025/5/19 16:23, Krzysztof Kozlowski wrote:
> On Mon, May 19, 2025 at 02:56:03PM GMT, Chaoyi Chen wrote:
> > Hi Krzysztof,
> >
> > On 2025/5/19 14:16, Krzysztof Kozlowski wrote:
> > > On 19/05/2025 03:26, Chaoyi Chen wrote:
> > > > +maintainers:
> > > > +  - Andy Yan <andy.yan@xxxxxxxxxxxxx>
> > > > +  - Heiko Stuebner <heiko@xxxxxxxxx>
> > > > +  - Sandy Huang <hjc@xxxxxxxxxxxxxx>
> > > > +
> > > > +allOf:
> > > > +  - $ref: /schemas/sound/dai-common.yaml#
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    items:
> > > > +      - const: rockchip,rk3399-cdn-dp
> > > > +
> > > > +  reg:
> > > > +    maxItems: 1
> > > > +
> > > > +  clocks:
> > > > +    items:
> > > > +      - description: DP core work clock
> > > > +      - description: APB clock
> > > > +      - description: SPDIF interface clock
> > > > +      - description: GRF clock
> > > > +
> > > > +  clock-names:
> > > > +    items:
> > > > +      - const: core-clk
> > > > +      - const: pclk
> > > > +      - const: spdif
> > > > +      - const: grf
> > > > +
> > > > +  extcon:
> > > > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > +    items:
> > > > +      maxItems: 1
> > > > +    maxItems: 2
> > > Instead of this, list the items. Old binding said only "specifier", so
> > > this is technically a change, which should be explained in commit msg.
> > Will fix in v5.
> >
> >
> > > > +    description:
> > > > +      List of phandle to the extcon device providing the cable state for the DP PHY.
> > > > +
> > > > +  interrupts:
> > > > +    maxItems: 1
> > > > +
> > > > +  phys:
> > > > +    items:
> > > > +      maxItems: 1
> > > > +    maxItems: 2
> > > > +    description: |
> > > > +      List of phandle to the PHY device for DP output.
> > > > +      RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use,
> > > > +      or specify two PHYs here to let the driver determine which PHY to use.
> > > You do not allow one phy, so your description is not accurate. OTOH,
> > > original binding did not allow two phandles, so that's another change in
> > > the binding. You need to document all changes done to the binding in the
> > > commit msg.
> > Oh, the original binding example use two phandles. I think only one PHY can
> Example is not the binding, just an example.
>
> > also pass the dtb check here, or maybe I'm missing something else?
> You think or you tested it? What is the minItems value? 2, so even if
> this works it's rather a bug in dtschema.

Yes I tested it. Both of "phys = <&tcphy0_dp>", "phys = <&tcphy0_dp>, 
<&tcphy1_dp>" pass the dtb check.


> Also, inner maxItems:1 is not really correct. Why can't this work with
> different phy providers?

I'll see what other bindings do. Thanks for the clarification!