Re: [PATCH] interconnect: qcom: sm8650: enable QoS configuration

[Pengyu Luo]

On Mon, 07 Apr 2025 17:16:47 +0200 Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
> Enable QoS configuration for master ports with predefined values
> for priority and urgency forwarding.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

[...]

> +static const struct regmap_config icc_regmap_config = {
> +	.reg_bits = 32,
> +	.reg_stride = 4,
> +	.val_bits = 32,
> +	.fast_io = true,
> +};

[...]

>  static const struct qcom_icc_desc sm8650_mc_virt = {
> +	.config = &icc_regmap_config,
>  	.nodes = mc_virt_nodes,
>  	.num_nodes = ARRAY_SIZE(mc_virt_nodes),
>  	.bcms = mc_virt_bcms,

Hi, Neil. It seems that the config for clk_virt, mc_virt is not working
on some devices. My device Oneplus Pad 2(pineappleP variant, mtp based,
but without modem) shown the following.

Apr 30 01:56:16 oneplus-caihong kernel: qnoc-sm8650 interconnect-0: error -EINVAL: invalid resource (null)
Apr 30 01:56:16 oneplus-caihong kernel: qnoc-sm8650 interconnect-1: error -EINVAL: invalid resource (null)

Best wishes,
Pengyu