Re: [PATCH v4 02/18] dt-bindings: clock: qcom: Update sc8280xp camcc bindings

From: Krzysztof Kozlowski
Date: Mon May 19 2025 - 04:19:32 EST


On Thu, May 15, 2025 at 12:38:47AM GMT, Jagadeesh Kona wrote:
> SC8280XP camcc only requires the MMCX power domain, unlike
> SM8450 camcc which will now support both MMCX and MXC power

I do not see change to sm8450 here. This makes no sense on its own. You
do not move compatibles - what is the point of such change?

> domains. Hence move SC8280XP camcc bindings from SM8450 to
> SA8775P camcc.

Subject: everything could be an update. Be specific.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>
> SA8775P camcc doesn't support required-opps property currently
> but SC8280XP camcc need that property, so add required-opps
> based on SC8280XP camcc conditional check in SA8775P camcc
> bindings.

Best regards,
Krzysztof