Re: [PATCH V12 06/15] rust: macros: enable use of hyphens in module names

[Benno Lossin]

On Mon May 19, 2025 at 9:07 AM CEST, Viresh Kumar wrote:
> From: Anisse Astier <anisse@xxxxxxxxx>
>
> Some modules might need naming that contains hyphens "-" to match the
> auto-probing by name in the platform devices that comes from the device
> tree.
>
> But rust identifiers cannot contain hyphens, so replace the module name
> by an underscore anywhere we'd use it as an identifier.

I think this is supposed to read "But Rust identifier cannot contain
hyphens, so replace them with underscores.".

> Signed-off-by: Anisse Astier <anisse@xxxxxxxxx>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> [Viresh: Replace "-" with '-', and fix line length checkpatch warnings]
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
>  rust/macros/module.rs | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

One nit below, with or without:

Reviewed-by: Benno Lossin <lossin@xxxxxxxxxx>

> diff --git a/rust/macros/module.rs b/rust/macros/module.rs
> index a9418fbc9b44..27cc72d474f0 100644
> --- a/rust/macros/module.rs
> +++ b/rust/macros/module.rs
> @@ -185,7 +185,9 @@ pub(crate) fn module(ts: TokenStream) -> TokenStream {
>  
>      let info = ModuleInfo::parse(&mut it);
>  
> -    let mut modinfo = ModInfoBuilder::new(info.name.as_ref());
> +    /* Rust does not allow hyphens in identifiers, use underscore instead */
> +    let name_identifier = info.name.replace('-', "_");

I think we could just name this variable `ident`.

---
Cheers,
Benno

> +    let mut modinfo = ModInfoBuilder::new(name_identifier.as_ref());
>      if let Some(author) = info.author {
>          modinfo.emit("author", &author);
>      }