Re: [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation

[Abdul Rahim, Faizal]

On 16/5/2025 5:43 pm, Simon Horman wrote:
> On Wed, May 14, 2025 at 12:29:45AM -0400, Faizal Rahim wrote:
> > From: Chwee-Lin Choong <chwee.lin.choong@xxxxxxxxx>
> >
> > A hardware-padded frame transmitted from the preemptible queue
> > results in an incorrect mCRC computation by hardware, as the
> > padding bytes are not included in the mCRC calculation.
> >
> > To address this, manually pad frames in preemptible queues to a
> > minimum length of 60 bytes using skb_padto() before transmission.
> > This ensures that the hardware includes the padding bytes in the
> > mCRC computation, producing a correct mCRC value.
> >
> > Signed-off-by: Chwee-Lin Choong <chwee.lin.choong@xxxxxxxxx>
> > Signed-off-by: Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx>
>
> Hi Faizal, all,
>
> Perhaps it would be best to shuffle this patch within this series
> so that it appears before the patches that add pre-emption support.
> That way, when the are added the bug isn't present.

Makes sense, will update. Thanks!