Re: [PATCH] ARM: integrator: Fix early initialization
From: Russell King (Oracle)
Date: Sun May 18 2025 - 13:48:21 EST
On Sun, May 18, 2025 at 09:41:18AM -0700, Guenter Roeck wrote:
> Starting with commit bdb249fce9ad4 ("ARM: integrator: read counter using
> syscon/regmap"), intcp_init_early calls syscon_regmap_lookup_by_compatible
> which in turn calls of_syscon_register. This function allocates memory.
> Since the memory management code has not been initialized at that time,
> the call always fails. It either returns -ENOMEM or crashes as follows.
Yet I see no thought whether having the scheduler see sched_clock()
suddenly change is a good idea or not. The point of the initialisation
being early is to avoid a jump in the scheduler clock.
So, was the commit you're trying to fix a good idea after all?
That question at least needs to be considered, rather than just moving
stuff like this later.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!