Re: [PATCH v4 4/4] mm/page_isolation: remove migratetype parameter from more functions.

[Zi Yan]

On 18 May 2025, at 12:32, Johannes Weiner wrote:

> On Fri, May 09, 2025 at 04:01:11PM -0400, Zi Yan wrote:
>> @@ -22,8 +22,25 @@ static inline bool is_migrate_isolate(int migratetype)
>>  }
>>  #endif
>>
>> -#define MEMORY_OFFLINE	0x1
>> -#define REPORT_FAILURE	0x2
>> +/*
>> + * Isolation modes:
>> + * ISOLATE_MODE_NONE - isolate for other purposes than those below
>> + * MEMORY_OFFLINE    - isolate to offline (!allocate) memory e.g., skip over
>> + *		       PageHWPoison() pages and PageOffline() pages.
>> + * CMA_ALLOCATION    - isolate for CMA allocations
>> + */
>> +enum isolate_mode_t {
>> +	ISOLATE_MODE_NONE,
>> +	MEMORY_OFFLINE,
>> +	CMA_ALLOCATION,
>> +};
>> +
>> +/*
>> + * Isolation flags:
>> + * REPORT_FAILURE - report details about the failure to isolate the range
>> + */
>> +typedef unsigned int __bitwise isolate_flags_t;
>> +#define REPORT_FAILURE		((__force isolate_flags_t)BIT(0))
>>
>>  void set_pageblock_migratetype(struct page *page, int migratetype);
>>  void set_pageblock_isolate(struct page *page);
>> @@ -32,10 +49,10 @@ bool pageblock_isolate_and_move_free_pages(struct zone *zone, struct page *page)
>>  bool pageblock_unisolate_and_move_free_pages(struct zone *zone, struct page *page);
>>
>>  int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
>> -			     int migratetype, int flags);
>> +			     isolate_mode_t mode, isolate_flags_t flags);
>
> This should be 'enum isolate_mode_t', right?
>
> (isolate_mode_t also exists, but it's something else)

Oh, I did not realize that. Let me rename it to pb_isolate_mode_t.
Thanks.

--
Best Regards,
Yan, Zi