Re: [PATCH v3 2/3] iio: light: add support for veml6046x00 RGBIR color sensor

[Andreas Klinger]

Hi Jonathan,

thanks for the review.

Jonathan Cameron <jic23@xxxxxxxxxx> schrieb am Do, 15. Mai 17:37:
> > +/*
> > + * Factors for lux / raw count in dependency of integration time (IT) as rows
> > + * and driver gain in columns
> > + * Columns:
> > + * x0.25 x0.33 x0.5 x0.66 x1 x2
> > + * Rows:
> > + * 3.125 6.25 12.5 25 50 100 200 400ms
> > + */
> > +static const u32 veml6046x00_it_gains[][6][2] = {
> > +{{5, 376000}, {4,  72700}, {2, 688000}, {2,  36400}, {1, 344000}, {0, 672000}},
> > +{{2, 688000}, {2,  36350}, {1, 344000}, {1,  18200}, {0, 672000}, {0, 336000}},
> > +{{1, 344000}, {1,  18175}, {0, 672000}, {0, 509100}, {0, 336000}, {0, 168000}},
> > +{{0, 672000}, {0, 509087}, {0, 336000}, {0, 254550}, {0, 168000}, {0,  84000}},
> > +{{0, 336000}, {0, 254543}, {0, 168000}, {0, 127275}, {0,  84000}, {0,  42000}},
> > +{{0, 168000}, {0, 127271}, {0,  84000}, {0,  63637}, {0,  42000}, {0,  21000}},
> > +{{0,  84000}, {0,  63635}, {0,  42000}, {0,  31818}, {0,  21000}, {0,  10500}},
> > +{{0,  42000}, {0,  31817}, {0,  21000}, {0,  15909}, {0,  10500}, {0,   5250}},
> I'd prefer
>    { { 0,  42000 }, { 0,   31817 }, etc for this formatting.
> Don't worry about going a little over 80 chars to do so - I think the readability
> makes it worth while.

I tried it and ended up with 101 characters in a line. I'll pick up the
suggestion of Andy for the next version.

Andreas

--

Attachment: signature.asc
Description: PGP signature