Re: [PATCH 1/3] dt-bindings: media: Add qcom,qcs615-camss binding

[Dmitry Baryshkov]

On Sun, May 18, 2025 at 02:33:07PM +0800, Wenmeng Liu wrote:
> Add bindings for qcom,qcs615-camss in order to support the camera
> subsystem for qcs615.
> 
> Signed-off-by: Wenmeng Liu <quic_wenmliu@xxxxxxxxxxx>
> ---
>  .../bindings/media/qcom,qcs615-camss.yaml          | 356 +++++++++++++++++++++
>  1 file changed, 356 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..9a87243f88d4b739cc29033509878ae706d3017f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,qcs615-camss.yaml
> @@ -0,0 +1,356 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,qcs615-camss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QCS615 Camera Subsystem (CAMSS)
> +

[...]

> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/clock/qcom,qcs615-camcc.h>
> +    #include <dt-bindings/clock/qcom,qcs615-gcc.h>

Could you please update internal guidelines: when adding support for new
hardware, don't use bindings for clock controllers, use ephemeral clocks
instead. See below.

> +    #include <dt-bindings/interconnect/qcom,icc.h>
> +    #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/power/qcom-rpmpd.h>
> +
> +
> +            clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
> +                     <&camcc CAM_CC_CPAS_AHB_CLK>,


So this can become <&camcc_camnoc_axi_clk>, <&camnoc_cpas_ahb_clk>, etc.

> +                     <&camcc CAM_CC_CPHY_RX_CLK_SRC>,

-- 
With best wishes
Dmitry