Re: [PATCH net-next v2 7/8] gve: Add support for SIOC[GS]HWTSTAMP IOCTLs

[Jakub Kicinski]

On Sat, 17 May 2025 00:11:09 +0000 Harshitha Ramamurthy wrote:
> Subject: [PATCH net-next v2 7/8] gve: Add support for SIOC[GS]HWTSTAMP IOCTLs

Sorry for the very shallow review, the subject jumped out at me.
You're not implementing the shouty ioctl, you're adding ndos.

> +	if (kernel_config->tx_type != HWTSTAMP_TX_OFF) {
> +		dev_err(&priv->pdev->dev, "TX timestamping is not supported\n");

please use extack

> +		return -ERANGE;
> +	}
> +
> +	if (kernel_config->rx_filter != HWTSTAMP_FILTER_NONE) {
> +		kernel_config->rx_filter = HWTSTAMP_FILTER_ALL;
> +		if (!priv->nic_ts_report) {
> +			err = gve_init_clock(priv);
> +			if (err) {
> +				dev_err(&priv->pdev->dev,
> +					"Failed to initialize GVE clock\n");

and here. Remember to remove the \n when converting.