Re: [PATCH 3/7] serial: 8250: Add PRUSS UART driver

[Judith Mendez]

Hi Greg,

On 5/14/25 2:36 AM, Greg Kroah-Hartman wrote:
> On Tue, May 13, 2025 at 04:59:30PM -0500, Judith Mendez wrote:
> > From: Bin Liu <b-liu@xxxxxx>
> >
> > This adds a new serial 8250 driver that supports the UART in PRUSS or
> > PRU_ICSS*.
> >
> > The UART sub-module is based on the industry standard TL16C550 UART
> > controller, which has 16-bytes FIFO and supports 16x and 13x over
> > samplings.
>
> If it is based on an existing controller, why do we need a new driver
> for this?  Please explain in detail why this code is needed at all, and
> not just a new "quirk" for the existing driver?

This was explained in RFC [0] but the patch description can be improved
so will fix for v2.

[0] https://lore.kernel.org/all/ba88a5c0-a8b8-4e48-9752-76881fa8e94e@xxxxxx/

Thanks
~ Judith